257 pin dialog does not popup when using is servicetap (#258)

Need this urgently as it affects the use of the PIN for tap menu items.
This commit is contained in:
__JosephAbbey
2025-07-18 20:51:10 +01:00
committed by GitHub
2 changed files with 2 additions and 1 deletions

View File

@ -44,3 +44,4 @@
| 2.29 | Added support for three new devices, Forerunners 570 42mm & 47mm and 970. |
| 2.30 | <img src="images/Venu2_glance_default.png" width="200" title="Default Glance"/><br/>Extensive re-work of the [Glance](examples/Glance.md) view, including the ability to customise it with a user supplied template. |
| 2.31 | Adding [two new options](./examples/Actions.md#exit-on-tap) to the menu items: 1) The ability to disable a menu item, e.g. temporarily for seasonal changes, 2) The option to exit after a menu item has been select. |
| 2.32 | Bug fix for a breaking change extracting options caused by the need to rearrange function parameters for an [annoying compiler error](https://github.com/house-of-abbey/GarminHomeAssistant/issues/253). |

View File

@ -69,7 +69,7 @@ class HomeAssistantTapMenuItem extends HomeAssistantMenuItem {
mData = data;
mExit = options.get(:exit);
mConfirm = options.get(:confirm);
mPin = options.get(:acospin);
mPin = options.get(:pin);
}
//! Call a Home Assistant service only after checks have been done for confirmation or PIN entry.