From f6d0916315775f6e100d59ba29ae5f5b5ef76626 Mon Sep 17 00:00:00 2001 From: Philip Abbey Date: Fri, 18 Jul 2025 20:46:49 +0100 Subject: [PATCH 1/2] Update HomeAssistantTapMenuItem.mc Requirement for use of the PIN was not being correctly extracted from the options. Goes to show why the security features should not be relied on! A recent compilation fix created this breaking change. --- source/HomeAssistantTapMenuItem.mc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/HomeAssistantTapMenuItem.mc b/source/HomeAssistantTapMenuItem.mc index 79a61ea..88aabaa 100644 --- a/source/HomeAssistantTapMenuItem.mc +++ b/source/HomeAssistantTapMenuItem.mc @@ -69,7 +69,7 @@ class HomeAssistantTapMenuItem extends HomeAssistantMenuItem { mData = data; mExit = options.get(:exit); mConfirm = options.get(:confirm); - mPin = options.get(:acospin); + mPin = options.get(:pin); } //! Call a Home Assistant service only after checks have been done for confirmation or PIN entry. From 3672a598fb53b87a3b8f56401bd9bcfda1aa73e7 Mon Sep 17 00:00:00 2001 From: Philip Abbey Date: Fri, 18 Jul 2025 20:49:10 +0100 Subject: [PATCH 2/2] Update HISTORY.md Added v2.32 --- HISTORY.md | 1 + 1 file changed, 1 insertion(+) diff --git a/HISTORY.md b/HISTORY.md index 46f946b..f438f76 100644 --- a/HISTORY.md +++ b/HISTORY.md @@ -44,3 +44,4 @@ | 2.29 | Added support for three new devices, Forerunners 570 42mm & 47mm and 970. | | 2.30 |
Extensive re-work of the [Glance](examples/Glance.md) view, including the ability to customise it with a user supplied template. | | 2.31 | Adding [two new options](./examples/Actions.md#exit-on-tap) to the menu items: 1) The ability to disable a menu item, e.g. temporarily for seasonal changes, 2) The option to exit after a menu item has been select. | +| 2.32 | Bug fix for a breaking change extracting options caused by the need to rearrange function parameters for an [annoying compiler error](https://github.com/house-of-abbey/GarminHomeAssistant/issues/253). |