remi/GarminHomeAssistant
1
0
Fork 0
mirror of https://github.com/house-of-abbey/GarminHomeAssistant.git synced 2025-08-15 08:08:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for settings

Browse Source 
HTTP-Headers settings no longer crash the application on the device. Group settings removed as they could be be changed a second time due to a bug in the SDK.
This commit is contained in:
Philip Abbey
2025-08-10 14:08:52 +01:00
parent f224268554
commit dd484aa615
40 changed files with 30 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
source/Settings.mc
View File

@ -48,9 +48,9 @@ class Settings {
//! minutes
private static var mBatteryRefreshRate as Lang.Number = 15;
//! Additional user configurable HTTP header key
private static var mUserHeaderName as Lang.String = "";
private static var mUserHeaderName as Lang.String? = null;
//! Additional user configurable HTTP header value
private static var mUserHeaderValue as Lang.String = "";
private static var mUserHeaderValue as Lang.String? = null;
private static var mIsApp as Lang.Boolean = false;
private static var mHasService as Lang.Boolean = false;
//! Must keep the object so it doesn't get garbage collected.
@ -297,7 +297,8 @@ class Settings {
//! @return The augmented HTTP header options.
//
static function augmentHttpHeaders(options as Lang.Dictionary) {
if (mUserHeaderName != null && mUserHeaderName != "" && mUserHeaderValue != null && mUserHeaderValue != "") {
// Use 'm.length() > 0' here in preference to 'm != ""'. The latter makes the app crash on device but not in simulation.
if (mUserHeaderName != null && mUserHeaderName.length() > 0 && mUserHeaderValue != null && mUserHeaderValue.length() > 0) {
options[mUserHeaderName] = mUserHeaderValue;
}
return options;