remi/GarminHomeAssistant
1
0
Fork 0
mirror of https://github.com/house-of-abbey/GarminHomeAssistant.git synced 2025-07-13 08:18:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Review comment

Browse Source 
enable => enabled
This commit is contained in:
Philip Abbey
2025-07-10 18:24:30 +01:00
parent 5639ff5c42
commit 842a31a1cc
2 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
config.schema.json
View File

@ -48,8 +48,8 @@
}, },
"additionalProperties": false "additionalProperties": false
}, },
"enable": { "enabled": {
"$ref": "#/$defs/enable" "$ref": "#/$defs/enabled"
}, },
"exit": { "exit": {
"$ref": "#/$defs/exit" "$ref": "#/$defs/exit"
@ -82,8 +82,8 @@
"title": "Schema change:", "title": "Schema change:",
"description": "Use 'info' or 'tap' instead." "description": "Use 'info' or 'tap' instead."
}, },
"enable": { "enabled": {
"$ref": "#/$defs/enable" "$ref": "#/$defs/enabled"
} }
}, },
"required": ["name", "content", "type"], "required": ["name", "content", "type"],
@ -111,8 +111,8 @@
"tap_action": { "tap_action": {
"$ref": "#/$defs/tap_action" "$ref": "#/$defs/tap_action"
}, },
"enable": { "enabled": {
"$ref": "#/$defs/enable" "$ref": "#/$defs/enabled"
}, },
"exit": { "exit": {
"$ref": "#/$defs/exit" "$ref": "#/$defs/exit"
@ -136,8 +136,8 @@
"$ref": "#/$defs/type", "$ref": "#/$defs/type",
"const": "info" "const": "info"
}, },
"enable": { "enabled": {
"$ref": "#/$defs/enable" "$ref": "#/$defs/enabled"
} }
}, },
"required": ["name", "content", "type"], "required": ["name", "content", "type"],
@ -168,8 +168,8 @@
"tap_action": { "tap_action": {
"$ref": "#/$defs/tap_action" "$ref": "#/$defs/tap_action"
}, },
"enable": { "enabled": {
"$ref": "#/$defs/enable" "$ref": "#/$defs/enabled"
}, },
"exit": { "exit": {
"$ref": "#/$defs/exit" "$ref": "#/$defs/exit"
@ -206,8 +206,8 @@
"items": { "items": {
"$ref": "#/$defs/items" "$ref": "#/$defs/items"
}, },
"enable": { "enabled": {
"$ref": "#/$defs/enable" "$ref": "#/$defs/enabled"
} }
}, },
"required": ["name", "title", "type", "items"], "required": ["name", "title", "type", "items"],
@ -321,7 +321,7 @@
} }
] ]
}, },
"enable": { "enabled": {
"type": "boolean", "type": "boolean",
"default": true, "default": true,
"title": "Enable the menu item", "title": "Enable the menu item",

8
source/HomeAssistantView.mc
View File

@ -51,10 +51,10 @@ class HomeAssistantView extends WatchUi.Menu2 {
var confirm = false as Lang.Boolean or Null; var confirm = false as Lang.Boolean or Null;
var pin = false as Lang.Boolean or Null; var pin = false as Lang.Boolean or Null;
var data = null as Lang.Dictionary or Null; var data = null as Lang.Dictionary or Null;
var enable = true as Lang.Boolean or Null; var enabled = true as Lang.Boolean or Null;
var exit = false as Lang.Boolean or Null; var exit = false as Lang.Boolean or Null;
if (items[i].get("enable") != null) { if (items[i].get("enabled") != null) {
enable = items[i].get("enable"); // Optional enabled = items[i].get("enabled"); // Optional
} }
if (items[i].get("exit") != null) { if (items[i].get("exit") != null) {
exit = items[i].get("exit"); // Optional exit = items[i].get("exit"); // Optional
@ -69,7 +69,7 @@ class HomeAssistantView extends WatchUi.Menu2 {
pin = tap_action.get("pin"); // Optional pin = tap_action.get("pin"); // Optional
} }
} }
if (type != null && name != null && enable) { if (type != null && name != null && enabled) {
if (type.equals("toggle") && entity != null) { if (type.equals("toggle") && entity != null) {
addItem(HomeAssistantMenuItemFactory.create().toggle(name, entity, content, exit, confirm, pin)); addItem(HomeAssistantMenuItemFactory.create().toggle(name, entity, content, exit, confirm, pin));
} else if (type.equals("tap") && service != null) { } else if (type.equals("tap") && service != null) {