From 4dc31e3c65bf7ee2bf4ac8606ecd571b64da1863 Mon Sep 17 00:00:00 2001
From: Philip Abbey <philipabbey@users.noreply.github.com>
Date: Thu, 7 Mar 2024 22:14:25 +0000
Subject: [PATCH] Removed a widget only property

That should have been removed previously.
---
 resources/settings/properties.xml | 8 --------
 resources/settings/settings.xml   | 7 -------
 source/HomeAssistantApp.mc        | 6 ------
 source/Settings.mc                | 6 ------
 4 files changed, 27 deletions(-)

diff --git a/resources/settings/properties.xml b/resources/settings/properties.xml
index 7856d5f..24561d2 100644
--- a/resources/settings/properties.xml
+++ b/resources/settings/properties.xml
@@ -61,14 +61,6 @@
   -->
   <property id="menu_alignment" type="number">1</property>
 
-  <!--
-    Widget specific setting:
-    As soon as the menu has been fetched start show the menu of items.
-    This behaviour is inconsistent with the standard Garmin User Interface,
-    but has been requested by users so has been made the non-default option.
-  -->
-  <property id="widget_start_no_tap" type="boolean">false</property>
-
   <!--
     Enable the background service to send the clock battery level to Home Assistant.
   -->
diff --git a/resources/settings/settings.xml b/resources/settings/settings.xml
index 1bea8c8..85f5d09 100644
--- a/resources/settings/settings.xml
+++ b/resources/settings/settings.xml
@@ -82,13 +82,6 @@
     </settingConfig>
   </setting>
 
-  <setting
-    propertyKey="@Properties.widget_start_no_tap"
-    title="@Strings.SettingsWidgetStart"
-  >
-    <settingConfig type="boolean" />
-  </setting>
-
   <setting
     propertyKey="@Properties.enable_battery_level"
     title="@Strings.SettingsEnableBatteryLevel"
diff --git a/source/HomeAssistantApp.mc b/source/HomeAssistantApp.mc
index ed68118..bae504b 100644
--- a/source/HomeAssistantApp.mc
+++ b/source/HomeAssistantApp.mc
@@ -256,12 +256,6 @@ class HomeAssistantApp extends Application.AppBase {
     private function buildMenu(menu as Lang.Dictionary) {
         mHaMenu = new HomeAssistantView(menu, null);
         mQuitTimer.begin();
-        if (Settings.getIsWidgetStartNoTap()) {
-            // As soon as the menu has been fetched start show the menu of items.
-            // This behaviour is inconsistent with the standard Garmin User Interface, but has been
-            // requested by users so has been made the non-default option.
-            pushHomeAssistantMenuView();
-        }
         mItemsToUpdate = mHaMenu.getItemsToUpdate();
         // Start the continuous update process that continues for as long as the application is running.
         // The chain of functions from 'updateNextMenuItem()' calls 'updateNextMenuItem()' on completion.
diff --git a/source/Settings.mc b/source/Settings.mc
index 9114633..7b616ce 100644
--- a/source/Settings.mc
+++ b/source/Settings.mc
@@ -38,7 +38,6 @@ class Settings {
     private static var mAppTimeout            as Lang.Number  = 0;  // seconds
     private static var mConfirmTimeout        as Lang.Number  = 3;  // seconds
     private static var mMenuAlignment         as Lang.Number  = WatchUi.MenuItem.MENU_ITEM_LABEL_ALIGN_LEFT;
-    private static var mIsWidgetStartNoTap    as Lang.Boolean = false;
     private static var mIsBatteryLevelEnabled as Lang.Boolean = false;
     private static var mBatteryRefreshRate    as Lang.Number  = 15; // minutes
     private static var mIsApp                 as Lang.Boolean = false;
@@ -59,7 +58,6 @@ class Settings {
         mAppTimeout            = Properties.getValue("app_timeout");
         mConfirmTimeout        = Properties.getValue("confirm_timeout");
         mMenuAlignment         = Properties.getValue("menu_alignment");
-        mIsWidgetStartNoTap    = Properties.getValue("widget_start_no_tap");
         mIsBatteryLevelEnabled = Properties.getValue("enable_battery_level");
         mBatteryRefreshRate    = Properties.getValue("battery_level_refresh_rate");
 
@@ -148,10 +146,6 @@ class Settings {
         return mMenuAlignment; // Either WatchUi.MenuItem.MENU_ITEM_LABEL_ALIGN_RIGHT or WatchUi.MenuItem.MENU_ITEM_LABEL_ALIGN_LEFT
     }
 
-    static function getIsWidgetStartNoTap() as Lang.Boolean {
-        return mIsWidgetStartNoTap;
-    }
-
     static function unsetIsBatteryLevelEnabled() {
         mIsBatteryLevelEnabled = false;
         Properties.setValue("enable_battery_level", mIsBatteryLevelEnabled);