From 2a99069f489a601b176cd7e6ef932421d5e650a7 Mon Sep 17 00:00:00 2001 From: Philip Abbey Date: Thu, 21 Mar 2024 19:29:52 +0000 Subject: [PATCH] Review comments --- source/HomeAssistantApp.mc | 10 +++++----- source/Settings.mc | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/source/HomeAssistantApp.mc b/source/HomeAssistantApp.mc index aa701c3..5fef154 100644 --- a/source/HomeAssistantApp.mc +++ b/source/HomeAssistantApp.mc @@ -261,7 +261,7 @@ class HomeAssistantApp extends Application.AppBase { // Start the continuous update process that continues for as long as the application is running. // The chain of functions from 'updateNextMenuItem()' calls 'updateNextMenuItem()' on completion. if (mItemsToUpdate.size() > 0) { - updateNextMenuItemInt(); + updateNextMenuItemInternal(); } } @@ -397,21 +397,21 @@ class HomeAssistantApp extends Application.AppBase { function updateNextMenuItem() as Void { var delay = Settings.getPollDelay(); if ((delay > 0) and (mNextItemToUpdate == 0)) { - mUpdateTimer.start(method(:updateNextMenuItemInt), delay, false); + mUpdateTimer.start(method(:updateNextMenuItemInternal), delay, false); } else { - updateNextMenuItemInt(); + updateNextMenuItemInternal(); } } // We need to spread out the API calls so as not to overload the results queue and cause Communications.BLE_QUEUE_FULL // (-101) error. This function is called by a timer every Globals.menuItemUpdateInterval ms. - function updateNextMenuItemInt() as Void { + function updateNextMenuItemInternal() as Void { var itu = mItemsToUpdate as Lang.Array; if (itu != null) { itu[mNextItemToUpdate].getState(); mNextItemToUpdate = (mNextItemToUpdate + 1) % itu.size(); // } else { - // System.println("HomeAssistantApp updateNextMenuItemInt(): No menu items to update"); + // System.println("HomeAssistantApp updateNextMenuItemInternal(): No menu items to update"); } } diff --git a/source/Settings.mc b/source/Settings.mc index 5197298..f6c903d 100644 --- a/source/Settings.mc +++ b/source/Settings.mc @@ -36,7 +36,7 @@ class Settings { private static var mClearCache as Lang.Boolean = false; private static var mVibrate as Lang.Boolean = false; private static var mAppTimeout as Lang.Number = 0; // seconds - private static var mPollDelay as Lang.Number = 0; // milliseconds + private static var mPollDelay as Lang.Number = 0; // seconds private static var mConfirmTimeout as Lang.Number = 3; // seconds private static var mMenuAlignment as Lang.Number = WatchUi.MenuItem.MENU_ITEM_LABEL_ALIGN_LEFT; private static var mIsBatteryLevelEnabled as Lang.Boolean = false;